Rework stac api extension logic #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This was
linked to
issues
Apr 12, 2024
for more information, see https://pre-commit.ci
omad
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters to
SummaryStore.search_itemsto enable factoring thefilterandsortbyextensions into the database query, thus moving the logic out of_handle_search_requestandsearch_stac_itemsin_stac.py, where it was previously causing issues when results were paginated, as highlighted in #579.Also took the opportunity to fix logic that was missing or out of line with the STAC API spec, such as reported in #536 and initially attempted in #570.
The STAC API extension specs are sometimes unclear or ambiguous around expected behaviour, so I have chosen to interpret them in the ways that seem the most reasonable and consistent. Most notably,
sortbywill ignore any undefined properties,sortbyandfilterwill recognise any potential variant of a property name (stac name (ex:created), eo3 name (ex:odc:processing_datetime), and metadata type search field name (ex:creation_time)) as syntactically valid for that property.📚 Documentation preview 📚: https://datacube-explorer--591.org.readthedocs.build/en/591/